HDDS-14198. Reduce parameter count in BucketEndpoint#9528
Merged
adoroszlai merged 1 commit intoapache:masterfrom Dec 19, 2025
Merged
HDDS-14198. Reduce parameter count in BucketEndpoint#9528adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
added
s3
rich7420
approved these changes
Dec 19, 2025
sodonnel
approved these changes
Dec 19, 2025
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. The only thing I thought was that its a little strange that all the params get removed from the methods parameter list except those with defaults. I'm fine with them staying like this, but is another option to put the default into the getQueryParam() method and overload it? Eg:
getQueryParam(QueryParams.CONTINUATION_TOKEN);
or
getQueryParam(QueryParams.QueryParams.MAX_KEYS, 1000);
This comment is optional, only do it if you think it makes sense, in this or another PR.
Contributor
Author
|
Thanks @sodonnel for the review.
Those are primitive |
Contributor
Author
|
Thanks @ivandika3, @rich7420, @sodonnel for the review. |
echonesis
pushed a commit
to echonesis/ozone
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce parameter count in
BucketEndpointrequest handler by getting query parameters from the request context.Benefits:
BucketEndpoint.parameternumberwarning.CC @echonesis
https://issues.apache.org/jira/browse/HDDS-14198
How was this patch tested?
Ran checkstyle and all S3G unit/integration tests locally.
CI:
https://github.com/adoroszlai/ozone/actions/runs/20363080334